Skip to content

master #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 20, 2014
Merged

master #2

merged 4 commits into from
Jun 20, 2014

Conversation

maiflai
Copy link
Contributor

@maiflai maiflai commented Jun 19, 2014

scoverage core libraries require a separate report step

@maiflai
Copy link
Contributor Author

maiflai commented Jun 20, 2014

This pull request is not quite complete - I think the following issues remain:

  • Source highlighting is not supported (does this require the additional compiler arg '-Yrangepos'?)
  • HTML reports do not link properly to the underlying source files
  • The travis build attempts to upload a snapshot to Sonatype - is this appropriate when testing a pull request?

Thanks,
Stu

@0xRoch
Copy link
Member

0xRoch commented Jun 20, 2014

Hi Stu,

Thank you for your pull request !
You are right it should only be uploading SNAPSHOTS when we merge on the master branch, I'll fix it.

0xRoch added a commit that referenced this pull request Jun 20, 2014
@0xRoch
Merge pull request #2 from maiflai/master
219ef47 
master
@0xRoch 0xRoch merged commit 219ef47 into scoverage:master Jun 20, 2014
maiflai pushed a commit that referenced this pull request Jul 5, 2015
@Kwestor
Merge pull request #2 from maiflai/fix-separate-tests
7268df0 
fix separate-tests project: add dependency on a-tests main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maiflai @0xRoch